gianm commented on PR #18147: URL: https://github.com/apache/druid/pull/18147#issuecomment-2988529413
> To nicely wire up the dependencies and the SDK, I am currently evaluating two alternatives described below. > > I am leaning towards B. What are your thoughts? IMO, tests for a module or an extension should live in that module or extension. This helps us organize the tests better, and also makes it possible for people with their own site-specific extensions to leverage the simulation test system. To me that means option B is preferred. Option A, where the simulation test module actually contains all the test cases, is not desirable because the tests don't get to live where they "should be". If a test needs to use multiple extensions, at that point it could live in a a test-specific module. Something like: - module `services` contains the simulation test system in its `test` tree, plus a few basic tests - other modules contain tests specific to that module, and depend on the `test-jar` for `services` ; for example this may be useful for `druid-basic-security` - module `simulation-tests` depends on a variety of extensions and contains tests that need to use multiple extensions It's kind of a blend of options A and B. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
