uds5501 commented on code in PR #18163:
URL: https://github.com/apache/druid/pull/18163#discussion_r2158646655
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -940,17 +941,8 @@ public SeekableStreamSupervisor(
spec.isSuspended()
);
- int workerThreads;
if (autoScalerConfig != null &&
autoScalerConfig.getEnableTaskAutoScaler()) {
log.info("Running Task autoscaler for supervisor[%s] for
datasource[%s]", supervisorId, dataSource);
-
- workerThreads = (this.tuningConfig.getWorkerThreads() != null
Review Comment:
> If workerThreads are specified, honor that config.
fair enough, otherwise this PR should've addressed removal of the tuning
configs as well. Will accommodate these suggestions.
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -940,17 +941,8 @@ public SeekableStreamSupervisor(
spec.isSuspended()
);
- int workerThreads;
if (autoScalerConfig != null &&
autoScalerConfig.getEnableTaskAutoScaler()) {
log.info("Running Task autoscaler for supervisor[%s] for
datasource[%s]", supervisorId, dataSource);
-
- workerThreads = (this.tuningConfig.getWorkerThreads() != null
Review Comment:
> If workerThreads are specified, honor that config.
fair enough, otherwise this PR should've addressed removal of the tuning
configs as well. Will accommodate these suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
