kfaraz commented on code in PR #18163:
URL: https://github.com/apache/druid/pull/18163#discussion_r2159827677
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -940,17 +941,8 @@ public SeekableStreamSupervisor(
spec.isSuspended()
);
- int workerThreads;
if (autoScalerConfig != null &&
autoScalerConfig.getEnableTaskAutoScaler()) {
log.info("Running Task autoscaler for supervisor[%s] for
datasource[%s]", supervisorId, dataSource);
-
- workerThreads = (this.tuningConfig.getWorkerThreads() != null
Review Comment:
Thanks, @uds5501 .
Just to clarify, when `workerThreads` is specified, we should use it
exactly, without dividing by a factor.
Otherwise, we are changing the semantics of this config which is not
desirable and also confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
