gianm commented on code in PR #18164:
URL: https://github.com/apache/druid/pull/18164#discussion_r2162417769
##########
extensions-contrib/compressed-bigdecimal/src/main/java/org/apache/druid/compressedbigdecimal/aggregator/max/CompressedBigDecimalMaxAggregatorFactory.java:
##########
@@ -110,6 +113,12 @@ public AggregateCombiner<CompressedBigDecimal>
makeAggregateCombiner()
return new CompressedBigDecimalMaxAggregateCombiner();
}
+ @Override
+ public AggregatorFactory withName(String newName)
+ {
+ return new CompressedBigDecimalMaxAggregatorFactory(newName, fieldName,
size, scale, strictNumberParsing);
Review Comment:
Was this the fix (along with similar changes in min, sum)?
##########
docs/development/extensions-contrib/compressed-big-decimal.md:
##########
@@ -144,6 +144,31 @@ IngestionSpec syntax:
}
}
```
+
+Sql based ingestion sample query:
Review Comment:
"SQL-based" is how we usually write this.
##########
docs/development/extensions-contrib/compressed-big-decimal.md:
##########
@@ -144,6 +144,31 @@ IngestionSpec syntax:
}
}
```
+
+Sql based ingestion sample query:
+```sql
+
+REPLACE INTO "bigdecimal" OVERWRITE ALL
+WITH "ext" AS (
+ SELECT *
+ FROM TABLE(
+ EXTERN(
+
'{"type":"local","baseDir":""/home/user/sales/data/staging/invoice-data","filter":"invoice-001.20201208.txt"}',
+
'{"type":"csv","findColumnsFromHeader":false,"columns":["timestamp","itemName","saleAmount"]}',
+
'[{"name":"timestamp","type":"string"},{"name":"itemName","type":"string"},{"name":"saleAmount","type":"double"}]'
+ )
+ )
+)
+SELECT
+ TIME_PARSE(TRIM("timestamp")) AS "__time",
+ "itemName",
+ BIG_SUM("saleAmount") as amount
Review Comment:
To me it would make sense to test this by either:
- loading MSQ into the compressed-big-decimal extension as a test dependency;
- or, loading both in `quidem-ut`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
