cryptoe commented on code in PR #18164:
URL: https://github.com/apache/druid/pull/18164#discussion_r2166053794
##########
extensions-contrib/compressed-bigdecimal/src/main/java/org/apache/druid/compressedbigdecimal/aggregator/max/CompressedBigDecimalMaxAggregatorFactory.java:
##########
@@ -110,6 +113,12 @@ public AggregateCombiner<CompressedBigDecimal>
makeAggregateCombiner()
return new CompressedBigDecimalMaxAggregateCombiner();
}
+ @Override
+ public AggregatorFactory withName(String newName)
+ {
+ return new CompressedBigDecimalMaxAggregatorFactory(newName, fieldName,
size, scale, strictNumberParsing);
Review Comment:
Yes it was adding the withName implementation to the other aggregator
factories.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
