imply-cheddar commented on code in PR #18182:
URL: https://github.com/apache/druid/pull/18182#discussion_r2176376633
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/actions/SegmentTransactionalInsertActionTest.java:
##########
@@ -217,10 +218,11 @@ public void test_fail_badVersion() throws Exception
actionTestKit.getTaskLockbox().add(task);
acquireTimeChunkLock(TaskLockType.EXCLUSIVE, task, INTERVAL, 5000);
- IllegalStateException exception = Assert.assertThrows(
- IllegalStateException.class,
+ DruidException exception = Assert.assertThrows(
+ DruidException.class,
() -> action.perform(task, actionTestKit.getTaskActionToolbox())
);
+ Assert.assertEquals(DruidException.Category.FORBIDDEN,
exception.getCategory());
Review Comment:
Why not use the `DruidExceptionMatcher`?
##########
docs/configuration/index.md:
##########
@@ -1475,7 +1475,7 @@ For most types of tasks, `SegmentWriteOutMediumFactory`
can be configured per-ta
|`druid.indexer.task.storeEmptyColumns`|Boolean value for whether or not to
store empty columns during ingestion. When set to true, Druid stores every
column specified in the
[`dimensionsSpec`](../ingestion/ingestion-spec.md#dimensionsspec). <br/><br/>If
you set `storeEmptyColumns` to false, Druid SQL queries referencing empty
columns will fail. If you intend to leave `storeEmptyColumns` disabled, you
should either ingest placeholder data for empty columns or else not query on
empty columns.<br/><br/>You can overwrite this configuration by setting
`storeEmptyColumns` in the [task
context](../ingestion/tasks.md#context-parameters).|true|
|`druid.peon.taskActionClient.retry.minWait`|The minimum retry time to
communicate with Overlord.|`PT5S`|
|`druid.peon.taskActionClient.retry.maxWait`|The maximum retry time to
communicate with Overlord.|`PT1M`|
-|`druid.peon.taskActionClient.retry.maxRetryCount`|The maximum number of
retries to communicate with Overlord.|60|
+|`druid.peon.taskActionClient.retry.maxRetryCount`|The maximum number of
retries to communicate with Overlord.|20 (about 10 minutes of retrying)|
Review Comment:
20 is 17.5 minutes of retries, not 10 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
