gianm commented on code in PR #18182:
URL: https://github.com/apache/druid/pull/18182#discussion_r2176427724
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/TaskLocks.java:
##########
@@ -57,7 +58,7 @@ static void checkLockCoversSegments(
)
{
if (!isLockCoversSegments(task, taskLockbox, segments)) {
- throw new ISE(
+ throw Forbidden.exception(
Review Comment:
This is kind of hacky, since "Forbidden" leads to `403 Forbidden`, which is
meant for situations where an action is unauthorized based on security
configuration. IMO it would be better to return a different code, like `400 Bad
Request` or `409 Conflict`. Those are both considered nonretryable by the
standard retry policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
