uds5501 opened a new pull request, #18184:
URL: https://github.com/apache/druid/pull/18184
### Description
It's a patch for managing lifecycle of NamespaceExtractionCacheManager via
main lifecycle thread.
Note for reviewers -
I have modified the elements `CacheSchedulerTest` that checked whether the
`executors` have terminated or not because we are not explicitly passing in the
lifecycle anymore. I couldn't find a test where we would import LifeCycle
module in the UT and run this, so modified for now (open to removal as well)
<hr>
##### Key changed/added classes in this PR
* `NamespaceExtractionCacheManager.java`
* `OffHeapNamespaceExtractionCacheManager`
* `OnHeapNamespaceExtractionCacheManager`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
