clintropolis commented on code in PR #18170:
URL: https://github.com/apache/druid/pull/18170#discussion_r2190817820
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/BatchAppenderator.java:
##########
@@ -634,6 +634,7 @@ public ListenableFuture<Object> persistAll(@Nullable final
Committer committer)
numPersistedRows, bytesPersisted, persistMillis
);
log.info("Persist is done.");
+ clearTaskThreadContext();
Review Comment:
>Yeah, I set out to do that originally. But then I realized that these
threads are not reused for another task ID. They are always freshly created for
each task.
ah i see what you're saying about the thread, in that case, why clear it at
all? That might be less confusing, especially if there was a comment by
`setTaskThreadContext` about it. clearing it sometimes is what makes it look
like a mistake at a glance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
