capistrant commented on code in PR #18170:
URL: https://github.com/apache/druid/pull/18170#discussion_r2191090385
##########
server/src/main/java/org/apache/druid/segment/realtime/appenderator/BatchAppenderator.java:
##########
@@ -634,6 +634,7 @@ public ListenableFuture<Object> persistAll(@Nullable final
Committer committer)
numPersistedRows, bytesPersisted, persistMillis
);
log.info("Persist is done.");
+ clearTaskThreadContext();
Review Comment:
plus one to clint's comment. I'd say we either strictly make sure it is
cleared in a way that could be accurate if the threads were re-used for a
different taskId, or not clear it at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
