cecemei commented on PR #18176: URL: https://github.com/apache/druid/pull/18176#issuecomment-3047129363
Curious how is `SegmentDescriptor` used in `AcquireSegmentAction`? I thought it's enough to just use `DataSegment`? Also I kinda feel many `SegmentManager` logic could be moved to `DataSourceState` class, which could encapsulate better, e.x. segments must be all joinable or non joinable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
