clintropolis commented on PR #18176: URL: https://github.com/apache/druid/pull/18176#issuecomment-3076064751
>Curious how is SegmentDescriptor used in AcquireSegmentAction? I thought it's enough to just use DataSegment? `SegmentDescriptor` isn't strictly used by the `AcquireSegmentAction`, its more of a bit of tracking convenience for callers, which start out with a list of `SegmentDescriptor`, so that it is easy to associate the segment loading futures with the `SegmentDescriptor` originally requested. >Also I kinda feel many SegmentManager logic could be moved to DataSourceState class, which could encapsulate better, e.x. segments must be all joinable or non joinable. I would agree that there are possibly some changes that could be done here, but I'm not too motivated to do them in this PR since enough other stuff is already changing. At least `DataSourceState` is basically internal to `SegmentManager`, so it should be pretty easy to change stuff around later if we want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
