github-advanced-security[bot] commented on code in PR #18232: URL: https://github.com/apache/druid/pull/18232#discussion_r2198473930
########## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/DecoupledDartCalciteJoinQueryTest.java: ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.msq.test; + +import com.google.common.collect.ImmutableMap; +import org.apache.druid.query.JoinAlgorithm; +import org.apache.druid.query.QueryContexts; +import org.apache.druid.sql.calcite.CalciteJoinQueryTest; +import org.apache.druid.sql.calcite.NotYetSupported; +import org.apache.druid.sql.calcite.NotYetSupported.Modes; +import org.apache.druid.sql.calcite.NotYetSupported.NotYetSupportedProcessor; +import org.apache.druid.sql.calcite.QueryTestBuilder; +import org.apache.druid.sql.calcite.SqlTestFrameworkConfig; +import org.apache.druid.sql.calcite.planner.PlannerContext; +import org.junit.AssumptionViolatedException; +import org.junit.jupiter.api.Nested; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.RegisterExtension; + [email protected](DartComponentSupplier.class) +public abstract class DecoupledDartCalciteJoinQueryTest extends CalciteJoinQueryTest +{ + + @Nested + public static class BroadcastTest extends DecoupledDartCalciteJoinQueryTest + { + @Override + protected JoinAlgorithm joinAlgorithm() + { + return JoinAlgorithm.BROADCAST; + } + } + + @Nested + public static class SortMergeTest extends DecoupledDartCalciteJoinQueryTest + { + @Override + protected JoinAlgorithm joinAlgorithm() + { + return JoinAlgorithm.SORT_MERGE; + } + + @NotYetSupported(Modes.DD_JOIN_CONDITION_NORMALIZATION) + @Test + public void testJoinWithInputRefCondition() Review Comment: ## Missing Override annotation This method overrides [CalciteJoinQueryTest.testJoinWithInputRefCondition](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/druid/security/code-scanning/9404) ########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/logical/LogicalInputSpec.java: ########## @@ -19,39 +19,98 @@ package org.apache.druid.msq.logical; -import org.apache.druid.error.NotYetImplemented; import org.apache.druid.msq.input.InputSpec; import org.apache.druid.msq.input.stage.StageInputSpec; import org.apache.druid.msq.kernel.StageDefinitionBuilder; import org.apache.druid.msq.logical.stages.LogicalStage; +import org.apache.druid.msq.querykit.InputNumberDataSource; +import org.apache.druid.query.DataSource; import org.apache.druid.segment.column.RowSignature; +import org.apache.druid.sql.calcite.planner.querygen.SourceDescProducer.SourceDesc; + +import java.util.Collections; +import java.util.Set; /** * Represents an {@link InputSpec} for {@link LogicalStage}-s. */ public abstract class LogicalInputSpec { + public interface InputProperty + { + InputProperty BROADCAST = new Broadcast(); + } + + private static final class Broadcast implements InputProperty Review Comment: ## Constant interface anti-pattern Type Broadcast implements constant interface [InputProperty](1). [Show more details](https://github.com/apache/druid/security/code-scanning/9403) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
