kgyrtkirk commented on code in PR #18232:
URL: https://github.com/apache/druid/pull/18232#discussion_r2266053328
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/logical/StageMaker.java:
##########
@@ -91,13 +95,8 @@ private StageDefinitionBuilder
buildStageInternal(LogicalStage stage)
private StageDefinitionBuilder
buildFrameProcessorStage(AbstractFrameProcessorStage frameProcessorStage)
{
List<LogicalInputSpec> inputs = frameProcessorStage.getInputSpecs();
- List<InputSpec> inputSpecs = new ArrayList<>();
- for (LogicalInputSpec dagInputSpec : inputs) {
- inputSpecs.add(dagInputSpec.toInputSpec(this));
- }
+ StageDefinitionBuilder sdb = newStageDefinitionBuilder(inputs);
StageProcessor<?, ?> stageProcessor =
frameProcessorStage.buildStageProcessor(this);
- StageDefinitionBuilder sdb = newStageDefinitionBuilder();
- sdb.inputs(inputSpecs);
sdb.signature(frameProcessorStage.getLogicalRowSignature());
sdb.processor(stageProcessor);
sdb.shuffleSpec(MixShuffleSpec.instance());
Review Comment:
yes; its not necessarily efficient - it was always planned to enhance the
`StageMaker` a bit to identify stages which could be run together... but it was
left for later as that should not change anything but that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
