gianm commented on code in PR #18236:
URL: https://github.com/apache/druid/pull/18236#discussion_r2201252889
##########
services/src/test/java/org/apache/druid/cli/CliPeonTest.java:
##########
@@ -67,6 +70,17 @@
public class CliPeonTest
{
+ @BeforeClass
+ public static void beforeClass()
Review Comment:
Oh, I see, it's because the module is listed in
`services/src/test/resources/META-INF/services/org.apache.druid.initialization.DruidModule`,
because it has to be or else it can't load in embedded tests. And that means
it loads for _all_ injector tests in the `services` module. Then it throws an
error about the `SERVER_MEMORY_PROPERTY` value not being valid.
I think a better fix would be to update the `RuntimeInfoModule` to just do
nothing if `SERVER_MEMORY_PROPERTY` is not set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
