kfaraz commented on code in PR #18247: URL: https://github.com/apache/druid/pull/18247#discussion_r2205052495
########## examples/quickstart/tutorial/hadoop/docker/Dockerfile: ########## @@ -52,12 +52,12 @@ RUN rpm --import http://repos.azulsystems.com/RPM-GPG-KEY-azulsystems && \ rpm -ivh zulu-repo-${ZULU_REPO_VER}.noarch.rpm && \ yum -q -y update && \ yum -q -y upgrade && \ - yum -q -y install zulu17-jdk && \ + yum -q -y install zulu11-jdk && \ yum -q -y install nano net-tools telnet less unzip wget && \ yum clean all && \ rm -rf /var/cache/yum zulu-repo_${ZULU_REPO_VER}.noarch.rpm -ENV JAVA_HOME=/usr/lib/jvm/zulu17 +ENV JAVA_HOME=/usr/lib/jvm/zulu11 Review Comment: Why the downgrade? ########## indexing-service/src/main/java/org/apache/druid/indexing/common/config/TaskConfig.java: ########## @@ -162,7 +157,6 @@ private TaskConfig( String baseDir, File baseTaskDir, String hadoopWorkingPath, Review Comment: Should `defaultHadoopCoordinates` and `hadoopWorkingPath` be removed too? ########## indexing-hadoop/src/main/java/org/apache/druid/indexer/HadoopIndexTask.java: ########## @@ -833,7 +831,7 @@ public String runTask(String[] args) throws Exception // can be injected based on the configuration given in config.getSchema().getIOConfig().getMetadataUpdateSpec() final SegmentMetadataPublisher maybeHandler; if (config.isUpdaterJobSpecSet()) { - maybeHandler = new SegmentMetadataPublisher(INJECTOR.getInstance(IndexerMetadataStorageCoordinator.class)); + maybeHandler = new SegmentMetadataPublisher(HadoopTask.INJECTOR.getInstance(IndexerMetadataStorageCoordinator.class)); Review Comment: Just saw that `HadoopTask` has its own static `INJECTOR` and `EXTENSION_LOADER`. 😅 Didn't go through the whole thing but seems like a really hacky approach to load a bunch of classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
