clintropolis commented on PR #18247: URL: https://github.com/apache/druid/pull/18247#issuecomment-3075849787
>Does the injector and classpath dark magic still work properly with this change? I recall there is some gnarly stuff where we're inspecting the classloader, pulling the jars out of it, and using that to populate the Hadoop classpath. (If the Hadoop ITs pass, probably the answer is yes this still works) Yes, as far as I can tell everything is still working correctly. The Hadoop ITs don't actually pass for me because the query expectations it is doing afterwards are failing, but the ingestion tasks succeed (and i see the same query expectation failures before this change too, so I think it ok). >With this change, if someone removes the druid-hadoop-indexing jar, does Druid still work properly? If so that is great. I haven't actually tried this yet, but I think it should be possible after #18246, since the only remaining references are the `HadoopIndexTaskModule` references in `CliOverlord`, `CliMiddleManager`, `CliPeon`, and `CliIndexer` it should be pretty easy to unhook and leave out of the build. I'm actually going to see if I can just go ahead and get it to work as an actual extension after this gets merged, so might be able to do even better so that it can be left out by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
