cecemei commented on code in PR #18307:
URL: https://github.com/apache/druid/pull/18307#discussion_r2224377926
##########
processing/src/main/java/org/apache/druid/query/aggregation/LongSumAggregatorFactory.java:
##########
@@ -36,25 +36,49 @@ public class LongSumAggregatorFactory extends
SimpleLongAggregatorFactory
{
private final Supplier<byte[]> cacheKey;
+ /**
+ * If false, the aggregator will return null when there are no values to
aggregate. This is the default behavior.
+ * Otherwise, the aggregator must return a default non-null value. This is
only used internally and not user-facing.
+ */
Review Comment:
removed this javadoc since it's already covered by
`NullableNumericAggregator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
