kfaraz commented on code in PR #18302: URL: https://github.com/apache/druid/pull/18302#discussion_r2255783749
########## services/src/test/java/org/apache/druid/testing/embedded/EmbeddedDruidCluster.java: ########## @@ -232,13 +228,21 @@ public TestFolder getTestFolder() } /** - * The embedded Zookeeper server used by this cluster, if any. - * - * @throws NullPointerException if this cluster has no embedded zookeeper. + * Uses a container-friendly hostname for all embedded services, Druid as well + * as external. + */ + public EmbeddedDruidCluster useContainerFriendlyHostname() Review Comment: Fair point! All the existing embedded tests would still work if we always used the `containerFriendly` hostname. (since the Docker tests already use embedded services and they are able to connect to each other seamlessly) In fact, that's how it used to be (except we were using `InetAddress.getLocalHost().getCanonicalHostName()` instead of `InetAddress.getLocalHost().getHostAddress()`), but we changed it in #18228 as there were some apprehensions with using the canonical host name, ref https://github.com/apache/druid/pull/18228/files#r2197340379. But now that we are using the `getHostAddress()` which is simply the IP address, I think we can just stick to using the `containerFriendly` one all the time. cc: @clintropolis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
