kfaraz commented on code in PR #18302: URL: https://github.com/apache/druid/pull/18302#discussion_r2259611508
########## embedded-tests/src/test/java/org/apache/druid/testing/embedded/docker/IngestionBackwardCompatibilityDockerTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testing.embedded.docker; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.druid.client.coordinator.CoordinatorServiceClient; +import org.apache.druid.java.util.common.StringUtils; +import org.apache.druid.java.util.http.client.response.BytesFullResponseHandler; +import org.apache.druid.java.util.http.client.response.BytesFullResponseHolder; +import org.apache.druid.rpc.RequestBuilder; +import org.apache.druid.rpc.indexing.SegmentUpdateResponse; +import org.apache.druid.testing.DruidContainer; +import org.apache.druid.testing.embedded.EmbeddedDruidCluster; +import org.jboss.netty.handler.codec.http.HttpMethod; +import org.junit.jupiter.api.Nested; + +/** + * Runs some basic ingestion tests using {@code DruidContainers} to verify + * backward compatibility with old Druid images. + */ +public class IngestionBackwardCompatibilityDockerTest +{ + @Nested + public class Apache31 extends IngestionDockerTest + { + @Override + public EmbeddedDruidCluster createCluster() + { + coordinator.usingImage(DruidContainer.Image.APACHE_31); Review Comment: > But, the backwards compatibility test isn't intended to deploy the "current code". It wants to deploy a specific older version. So, it doesn't have that problem, and it's therefore good to always run it. Thanks for the suggestion! In that case, I will remove the skip annotation from the backward compatibility test and use only Druid 31 containers and embedded servers for it (currently it uses a mix of Druid 31 containers, current code Druid containers and embedded servers). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
