clintropolis commented on code in PR #18176: URL: https://github.com/apache/druid/pull/18176#discussion_r2289062650
########## server/src/main/java/org/apache/druid/segment/loading/CacheEntry.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.loading; + +import java.io.File; +import java.io.IOException; + +/** + * Common interface for items stored in a {@link StorageLocation} + */ +public interface CacheEntry +{ + /** + * Unique identifier for the cache entry + */ + CacheEntryIdentifier getId(); + + /** + * Size in bytes of the cache entry + */ + long getSize(); + + boolean isMounted(); + + /** + * Materializes the cache entry into the assigned {@link StorageLocation}. If a cache entry is already mounted in the + * location, calling this method should be a no-op. If the cache entry is mounted in a different location, this method + * will unmount the item from the other location and mount in the new location. Review Comment: i dont think there is a use case actually, i think mounting something already mounted in another place should be an error condition, will change this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
