clintropolis commented on code in PR #18176: URL: https://github.com/apache/druid/pull/18176#discussion_r2291845613
########## processing/src/main/java/org/apache/druid/segment/SegmentReference.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment; + +import org.apache.druid.java.util.common.io.Closer; +import org.apache.druid.query.SegmentDescriptor; +import org.apache.druid.segment.loading.AcquireSegmentAction; + +import java.io.Closeable; +import java.io.IOException; +import java.util.Optional; + +/** + * Wrapper for a {@link SegmentDescriptor} and {@link Optional<Segment>}, the latter being created by a + * {@link SegmentMapFunction} being applied to a {@link ReferenceCountedSegmentProvider}. Closing this object closes + * both the {@link #segmentReference} and any closeables attached from the process of creating this object, such as + * from {@link AcquireSegmentAction} + */ +public class SegmentReference implements Closeable +{ + public static SegmentReference missing(SegmentDescriptor segmentDescriptor) + { + return new SegmentReference(segmentDescriptor, Optional.empty(), AcquireSegmentAction.NOOP_CLEANUP); + } + + private final SegmentDescriptor segmentDescriptor; + private final Optional<Segment> segmentReference; + private final Closer closer = Closer.create(); + + public SegmentReference( + SegmentDescriptor segmentDescriptor, + Optional<Segment> segmentReference, + Closeable cleanupHold + ) + { + this.segmentDescriptor = segmentDescriptor; + this.segmentReference = segmentReference.map(closer::register); + closer.register(cleanupHold); Review Comment: i don't think it mattered much, but flipped -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
