maytasm opened a new pull request, #18426: URL: https://github.com/apache/druid/pull/18426
### Description Similar to https://github.com/apache/druid/pull/14312, Hll Sketch estimate with error bounds and Theta sketch estimate with error bounds can now be used as an expression. Hll Sketch estimate with error bounds and Theta sketch estimate with error bound have been used only as PostAggs as they work on groupBy and TopN queries. But postAggs are not supported for scan queries. In this PR we introduce HLL_SKETCH_ESTIMATE_WITH_ERROR_BOUNDS and THETA_SKETCH_ESTIMATE_WITH_ERROR_BOUNDS as expressions. These estimates work on a sketch column and has the same behavior as the postAggs. New test cases have been added to show how scan queries can work with these estimates. This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
