maytasm commented on code in PR #18426:
URL: https://github.com/apache/druid/pull/18426#discussion_r2301482362
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllPostAggExprMacros.java:
##########
@@ -24,17 +24,18 @@
import org.apache.druid.math.expr.ExprMacroTable;
import org.apache.druid.math.expr.ExpressionType;
import org.apache.druid.query.aggregation.datasketches.hll.HllSketchHolder;
+import
org.apache.druid.query.aggregation.datasketches.hll.HllSketchToEstimateWithBoundsPostAggregator;
import javax.annotation.Nullable;
import java.util.List;
public class HllPostAggExprMacros
{
public static final String HLL_SKETCH_ESTIMATE = "hll_sketch_estimate";
+ public static final String HLL_SKETCH_ESTIMATE_WITH_ERROR_BOUNDS =
"hll_sketch_estimate_with_error_bounds";
public static class HLLSketchEstimateExprMacro implements
ExprMacroTable.ExprMacro
{
-
Review Comment:
This method has an extra random newline while the others don't and the OCD
in me wants to remove it (so they all look the same).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
