This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 88bd9ab9253 Use daemon threads in
TestDartControllerContextFactoryImpl. (#18440)
88bd9ab9253 is described below
commit 88bd9ab9253ba88a3c455122a8fcdc3a57495264
Author: Gian Merlino <[email protected]>
AuthorDate: Wed Aug 27 01:17:59 2025 -0700
Use daemon threads in TestDartControllerContextFactoryImpl. (#18440)
The current approach uses non-daemon threads, which can block JVM shutdown.
---
.../apache/druid/msq/test/TestDartControllerContextFactoryImpl.java | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
a/multi-stage-query/src/test/java/org/apache/druid/msq/test/TestDartControllerContextFactoryImpl.java
b/multi-stage-query/src/test/java/org/apache/druid/msq/test/TestDartControllerContextFactoryImpl.java
index 83ba3900f4d..8f3fbe66988 100644
---
a/multi-stage-query/src/test/java/org/apache/druid/msq/test/TestDartControllerContextFactoryImpl.java
+++
b/multi-stage-query/src/test/java/org/apache/druid/msq/test/TestDartControllerContextFactoryImpl.java
@@ -23,7 +23,6 @@ import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.ListeningExecutorService;
import com.google.common.util.concurrent.MoreExecutors;
-import com.google.common.util.concurrent.ThreadFactoryBuilder;
import com.google.inject.Inject;
import com.google.inject.Injector;
import org.apache.druid.client.TimelineServerView;
@@ -31,6 +30,7 @@ import org.apache.druid.guice.annotations.EscalatedGlobal;
import org.apache.druid.guice.annotations.Json;
import org.apache.druid.guice.annotations.Self;
import org.apache.druid.guice.annotations.Smile;
+import org.apache.druid.java.util.common.concurrent.Execs;
import org.apache.druid.java.util.common.io.Closer;
import org.apache.druid.java.util.emitter.service.ServiceEmitter;
import org.apache.druid.java.util.metrics.StubServiceEmitter;
@@ -58,9 +58,7 @@ import java.util.concurrent.Executors;
public class TestDartControllerContextFactoryImpl extends
DartControllerContextFactoryImpl
{
private static final ListeningExecutorService EXECUTOR =
MoreExecutors.listeningDecorator(
- Executors.newCachedThreadPool(
- new ThreadFactoryBuilder().setNameFormat("dart-worker-%d").build()
- )
+ Executors.newCachedThreadPool(Execs.makeThreadFactory("dart-worker-%d"))
);
private final Map<String, WorkerRunRef> workerMap;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
