kfaraz commented on code in PR #18458:
URL: https://github.com/apache/druid/pull/18458#discussion_r2311790033


##########
extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json:
##########
@@ -77,6 +77,19 @@
   "query/cache/total/put/error" : { "dimensions" : [], "type" : "gauge", 
"help": "Total number of new cache entries that could not be cached due to 
errors."},
   "query/cache/total/put/oversized" : { "dimensions" : [], "type" : "gauge", 
"help": "Total number of potential new cache entries that were skipped due to 
being too large (based on druid.{broker,historical,realtime}.cache.maxEntrySize 
properties)."},
 
+  "kafka/consumer/bytesConsumed" : { "dimensions" : ["topic"], "type" : 
"count", "help": "Bytes consumed by the Kafka indexing task's consumer (per 
topic)."},

Review Comment:
   Instead of `Kafka indexing task's consumer`, should we use `consumer of a 
Kafka indexing task`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to