cryptoe commented on code in PR #18471:
URL: https://github.com/apache/druid/pull/18471#discussion_r2317765312
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -403,7 +403,7 @@ private void startPendingTasksOnRunner()
updateTaskEntry(taskId, entry -> {
if (entry == null) {
unknownTaskIds.add(taskId);
- shutdownUnknownTaskOnRunner(taskId);
+ shutdownTaskOnRunner(taskId, "Task is not present in queue
anymore.");
Review Comment:
Since now the shutdown is running in a new exec service, does it make sense
for us to adjust line 412 to mention that we *attempted* to clean up X tasks.
`
log.info("Attempted to cleaned up [%,d] tasks on task runner with IDs[%s].",
unknownTaskIds.size(), unknownTaskIds);
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
