kgyrtkirk commented on code in PR #18444:
URL: https://github.com/apache/druid/pull/18444#discussion_r2319013829
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -349,6 +356,24 @@ protected void startWatchingLogs()
}
protected void saveLogs()
+ {
+ ExecutorService executor = Executors.newSingleThreadExecutor();
Review Comment:
this seems to create a new executor for every call?
that looks a bit odd
I don't know how many additional patches will be needed to make this
fabric8+vertx stuff work correctly.
Would it be hard to add a knob which could restore the okhttp usage?
if we are about to handle the timeouts ourselves - is fabric8 the right
choice of library?
I was taking a quick glance at https://github.com/kubernetes-client/java and
it seemed more straightforward...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
