capistrant commented on code in PR #18444:
URL: https://github.com/apache/druid/pull/18444#discussion_r2319489480
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesPeonLifecycle.java:
##########
@@ -349,6 +356,24 @@ protected void startWatchingLogs()
}
protected void saveLogs()
+ {
+ ExecutorService executor = Executors.newSingleThreadExecutor();
Review Comment:
> this seems to create a new executor for every call? that looks a bit odd
new executor per task when this saveLogs is called once when task completes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
