jtuglu1 commented on code in PR #18480:
URL: https://github.com/apache/druid/pull/18480#discussion_r2325443828
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java:
##########
@@ -100,6 +103,9 @@ public LagBasedAutoScalerConfig(
this.scaleOutStep = scaleOutStep != null ? scaleOutStep : 2;
this.minTriggerScaleActionFrequencyMillis =
minTriggerScaleActionFrequencyMillis
!= null ? minTriggerScaleActionFrequencyMillis : 600000;
+
+ Preconditions.checkArgument(stopTaskCountPercent == null ||
(stopTaskCountPercent > 0.0 && stopTaskCountPercent <= 1.0), "0.0 <
stopTaskCountPercent <= 1.0");
Review Comment:
Value range is (0, 1.]. I don't really like the idea of using an int field
for this kind of thing. I'll switch the name to ratio.
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java:
##########
@@ -100,6 +103,9 @@ public LagBasedAutoScalerConfig(
this.scaleOutStep = scaleOutStep != null ? scaleOutStep : 2;
this.minTriggerScaleActionFrequencyMillis =
minTriggerScaleActionFrequencyMillis
!= null ? minTriggerScaleActionFrequencyMillis : 600000;
+
+ Preconditions.checkArgument(stopTaskCountPercent == null ||
(stopTaskCountPercent > 0.0 && stopTaskCountPercent <= 1.0), "0.0 <
stopTaskCountPercent <= 1.0");
Review Comment:
Value range is (0, 1.0]. I don't really like the idea of using an int field
for this kind of thing. I'll switch the name to ratio.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
