kfaraz commented on code in PR #18480:
URL: https://github.com/apache/druid/pull/18480#discussion_r2326393726
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java:
##########
@@ -212,6 +218,15 @@ public AggregateFunction getLagAggregate()
return lagAggregate;
}
+ @Override
+ @JsonProperty
+ @Nullable
+ @JsonInclude(JsonInclude.Include.NON_NULL)
Review Comment:
> I'd prefer to reserve this for fields which make sense to be nullable
I don't quite follow. A non-nullable field would never be null anyway.
The constructor would either assign a default value to it or throw an
exception.
For anyone reading the json, it doesn't make a real difference if the field
is absent or if it is assigned `"field": null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
