clintropolis commented on code in PR #18486:
URL: https://github.com/apache/druid/pull/18486#discussion_r2331559163
##########
processing/src/main/java/org/apache/druid/segment/projections/Projections.java:
##########
@@ -117,6 +121,11 @@ public static ProjectionMatch matchAggregateProjection(
if
(CollectionUtils.isNullOrEmpty(queryCursorBuildSpec.getPhysicalColumns())) {
return null;
}
+
+
+ if (isUnalignedInterval(projection, queryCursorBuildSpec, dataInterval)) {
Review Comment:
>also in line 382, it only checks for virtual column that only have __time
as required input, but there can be multiple required inputs and __time being
one of them, e.x. concat(column1, __time), in this case, granularity is not
checked. maybe we should update the condition to be
requiredInputs.contains("__time")
line 381 is checking that there is only 1 required input and that it is
__time, since only time_floor can be considered as a granularity, if it
requires __time but has only 1 input it requires none granularity. The else
clause handles all other expressions, such as the concat example by just making
sure all the input columns are required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
