capistrant commented on code in PR #18540:
URL: https://github.com/apache/druid/pull/18540#discussion_r2355592742
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesOverlordModule.java:
##########
@@ -79,7 +85,10 @@ public class KubernetesOverlordModule implements DruidModule
+
".k8sAndWorker";
private static final String RUNNERSTRATEGY_PROPERTIES_FORMAT_STRING =
K8SANDWORKER_PROPERTIES_PREFIX
+
".runnerStrategy.%s";
- private static final String HTTPCLIENT_PROPERITES_PREFIX =
K8SANDWORKER_PROPERTIES_PREFIX + ".http";
+ private static final String HTTPCLIENT_TYPE_PROPERTY =
K8SANDWORKER_PROPERTIES_PREFIX + ".http.httpClientType";
Review Comment:
I may or may not have been working on a commit to add docs after I realized
I forgot 😆 but we can leave un-documented I guess. But maybe putting it in the
extensions doc under an **experimental** label plus disclaimer that this is
temporary while the community determines best path forward for a generic config
that works well for all is good compromise. Then all users of the extension
could help find the best path forward if they so choose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
