gianm commented on code in PR #18540:
URL: https://github.com/apache/druid/pull/18540#discussion_r2361337917
##########
extensions-core/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesOverlordModule.java:
##########
@@ -79,7 +85,10 @@ public class KubernetesOverlordModule implements DruidModule
+
".k8sAndWorker";
private static final String RUNNERSTRATEGY_PROPERTIES_FORMAT_STRING =
K8SANDWORKER_PROPERTIES_PREFIX
+
".runnerStrategy.%s";
- private static final String HTTPCLIENT_PROPERITES_PREFIX =
K8SANDWORKER_PROPERTIES_PREFIX + ".http";
+ private static final String HTTPCLIENT_TYPE_PROPERTY =
K8SANDWORKER_PROPERTIES_PREFIX + ".http.httpClientType";
Review Comment:
That'd also be OK, I just don't want to create a reason to worry about
removing it in the future. If the doc page says that it may be removed in a
future release then that works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
