FrankChen021 commented on PR #18547: URL: https://github.com/apache/druid/pull/18547#issuecomment-3322235708
> Thanks for sharing the details, @GabrielCWT ! That sounds like a reasonable use case. > > My only concern was with adding a new type of free-form info to `DruidNode` since it is primarily used for service discovery. There can be issues with Zookeeper if a node ends up having very large label values, but I suppose it is not very likely to happen and would be a configuration issue rather than a code issue anyway. > > The alternative would be to just bind it to a completely new config object and then it would be served over the `/status/properties` API but then you wouldn't be able to display it on the web-console. I think it's better to show the label in the web console. Another use case is that we can inject some container meta data like container name to this property when druid is deployed in K8s, so that we know which service/host maps to which container from web-console -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
