GabrielCWT commented on code in PR #18547:
URL: https://github.com/apache/druid/pull/18547#discussion_r2374041858
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -180,6 +180,7 @@ public class SystemSchema extends AbstractSchema
.add("max_size", ColumnType.LONG)
.add("is_leader", ColumnType.LONG)
.add("start_time", ColumnType.STRING)
+ .add("labels", ColumnType.NESTED_DATA)
Review Comment:
Not sure if I misunderstood our previous discussion but the issue I was
facing was that when it was a `STRING` type, the data being returned for the
`Map` was in the form `"labels": "{brokerTest=myValue, brokerTest2=myValue2}"`,
therefore I used `jsonMapper` to serialise the labels.
We then agreed to return it in JSON format thus changing it to `NESTED_DATA`
type. Just want to confirm that you want to revert it back to the original
implementation
```
node.getLabels() == null ? null :
jsonMapper.writeValueAsString(node.getLabels())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
