kfaraz commented on code in PR #18569:
URL: https://github.com/apache/druid/pull/18569#discussion_r2378265725
##########
sql/src/main/java/org/apache/druid/sql/http/SqlResource.java:
##########
@@ -97,7 +98,8 @@ public SqlResource(
final SqlEngineRegistry sqlEngineRegistry,
final SqlResourceQueryResultPusherFactory resultPusherFactory,
final DefaultQueryConfig defaultQueryConfig,
- final ServerConfig serverConfig
+ final ServerConfig serverConfig,
+ final QueryCountStatsProvider counter
Review Comment:
> That should be done with tags IMO and not differing metrics.
By tags, do you mean metric dimensions? That would be okay too [as suggested
here](https://github.com/apache/druid/pull/18569#pullrequestreview-3265925315),
as long as there is some way to distinguish between the two. But even different
dimensions would still require you to collect the two stats separately via two
different instances of the stats provider.
> What happened before this change is these 2 *Resource classes diverged to
the point where there was gap in metrics between them.
Were SQL query count metrics ever emitted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
