jtuglu1 commented on code in PR #18569:
URL: https://github.com/apache/druid/pull/18569#discussion_r2379757131
##########
sql/src/main/java/org/apache/druid/sql/http/SqlResource.java:
##########
@@ -97,7 +98,8 @@ public SqlResource(
final SqlEngineRegistry sqlEngineRegistry,
final SqlResourceQueryResultPusherFactory resultPusherFactory,
final DefaultQueryConfig defaultQueryConfig,
- final ServerConfig serverConfig
+ final ServerConfig serverConfig,
+ final QueryCountStatsProvider counter
Review Comment:
An alternative might be to keep a single class/instance, but introduce 1
layer of indirection to increment/fetch the metrics. This could support future
combinations of (engine, queryFormat) where entries might look like (native,
native) or (native, SQL) or (msq, SQL), etc. This way you don't get an
explosion of unique metric names and/or annotated instances and that
cardinality is instead pushed into the dimensions under a unified metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
