jtuglu1 commented on code in PR #18148:
URL: https://github.com/apache/druid/pull/18148#discussion_r2409851779


##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunner.java:
##########
@@ -176,6 +176,8 @@ public Sequence<ResultRow> run(final QueryPlus<ResultRow> 
queryPlus, final Respo
     // query processing together.
     final long queryTimeout = queryContext.getTimeout();
     final boolean hasTimeout = queryContext.hasTimeout();
+    final boolean hasPerSegmentTimeout = queryContext.usePerSegmentTimeout();

Review Comment:
   Users should be able to set `druid.query.default.context.perSegmentTimeout` 
as a default setting as they can for all other context types.
   
   No, Let me add the context docs.



##########
processing/src/main/java/org/apache/druid/java/util/common/concurrent/DummyExecutorService.java:
##########
@@ -117,4 +120,38 @@ public void execute(Runnable command)
   {
     throw new UnsupportedOperationException();
   }
+
+  @Override
+  public @NotNull ScheduledFuture<?> schedule(@NotNull Runnable command, long 
delay, @NotNull TimeUnit unit)
+  {
+    throw new UnsupportedOperationException();
+  }
+
+  @Override
+  public @NotNull <V> ScheduledFuture<V> schedule(@NotNull Callable<V> 
callable, long delay, @NotNull TimeUnit unit)
+  {
+    throw new UnsupportedOperationException();
+  }
+
+  @Override
+  public @NotNull ScheduledFuture<?> scheduleAtFixedRate(
+      @NotNull Runnable command,
+      long initialDelay,
+      long period,
+      @NotNull TimeUnit unit
+  )
+  {
+    throw new UnsupportedOperationException();
+  }
+

Review Comment:
   I can remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to