kfaraz commented on PR #18631: URL: https://github.com/apache/druid/pull/18631#issuecomment-3404433275
@jtuglu1 , I had a few suggestions: - While the HTTP status code of a query does seem reasonably useful, it still provides very limited information. It only tells us whether a query failed with say 400 or 500 etc. It would be much more useful to include a short failure description (similar to what we do for `task/run/time` metric) or the failure Druid error code (the code inside the `DruidException` could be used for this). - The dimension name `code` is very ambiguous. Please use `errorCode` or `httpCode` instead. - I assume we are not emitting this dimension if the query was successful? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
