jtuglu1 commented on PR #18631: URL: https://github.com/apache/druid/pull/18631#issuecomment-3404448398
> It only tells us whether a query failed with say 400 or 500 This is by design. If operators want to know why their query failed, they should consult the query logs. At high volume, emitting a repeated long string doesn't provide that much value in the presence of logs IMO. > The dimension name code is very ambiguous. Please use errorCode or httpCode instead. Sure, will change in a follow-up. > I assume we are not emitting this dimension if the query was successful? We are emitting 200. That's the point of the status metric. It's a small piece of information for operators to easily aggregate on, etc. and not have to worry about odd edge cases like whether it's success=false, then go check `errorCode`,etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
