github-advanced-security[bot] commented on code in PR #18402:
URL: https://github.com/apache/druid/pull/18402#discussion_r2464654523
##########
server/src/test/java/org/apache/druid/server/metrics/LatchableEmitter.java:
##########
@@ -260,12 +262,11 @@
}
/**
- * Matches an event only if it has a metric value equal to or greater than
- * the given value.
+ * Matches an event only if the metric value satisfies the given matcher.
*/
- public EventMatcher hasValueAtLeast(long metricValue)
+ public EventMatcher hasValue(Matcher<Long> valueMatcher)
{
- this.metricValue = metricValue;
+ this.valueMatcher = valueMatcher;
Review Comment:
## Confusing overloading of methods
Method EventMatcher.hasDimension(..) could be confused with overloaded
method [hasDimension](1), since dispatch depends on static types.
[Show more
details](https://github.com/apache/druid/security/code-scanning/10232)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
