capistrant commented on code in PR #18402: URL: https://github.com/apache/druid/pull/18402#discussion_r2475543524
########## indexing-service/src/main/java/org/apache/druid/indexing/compact/MSQCompactionJobTemplate.java: ########## @@ -0,0 +1,191 @@ +/* Review Comment: when I was playing with this on my local I accidentally got into a state where I had defined an expected granularity of MONTH, but the query in the template was DAY. It looked like it just went into an infinite compact loop. Could we force the templated query to honor segment granularity from the state matcher by injecting it? I guess this forces everyone creating a rule to select a segment gran though, which is probably not desired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
