aho135 commented on PR #18719: URL: https://github.com/apache/druid/pull/18719#issuecomment-3494003423
> Thanks for the investigation and fix, @aho135! > > > The OshiSysMonitor DiskStats uses KeyedDiff which can occasionally lead to negative values for metrics such as sys/disk/write/size when the underlying long in HWDiskStore overflows. This kind of metric should arguably be configured as gauge. > > I agree that these metrics should be configured as gauges instead. Should we also fix the metric type in the `defaultMetrics.json` [config](https://github.com/apache/druid/blob/master/extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json#L226-L231)? (I think it'd apply to a few other emitters too) > > For any other metric misconfigurations, the exception handling should give us more insights into that I suppose. Thanks for the review @abhishekrb19 Yeah good point, let me update the metric type and take a look at other emitters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
