gianm commented on code in PR #18717:
URL: https://github.com/apache/druid/pull/18717#discussion_r2505273648


##########
.github/workflows/ci.yml:
##########
@@ -71,21 +72,6 @@ jobs:
       artifacts_to_download: "unit-test-reports-*"
       key: "coverage-jacoco"
 
-  run-unit-tests-all-jdk:

Review Comment:
   In the interests of making CI run faster, IMO it would be good to keep this, 
but flip 17 and 21. So, every PR runs java 21 tests and some run 17 tests. That 
way we're always doing our regular testing with the latest supported JDK. There 
is a tradeoff here in terms of catching stuff earlier, but I tend to believe 
that CI running quickly is worth the tradeoff.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to