kgyrtkirk commented on PR #18717: URL: https://github.com/apache/druid/pull/18717#issuecomment-3521159219
the purpose of it was to run the tests once on the primary jdk; and optional only then proceed to others (possibly reducing resource use if there are failed tests; note: around when this was made testing was run on 3 jdks) alternate jdk runs were deliberatlely skipped on PRs which were not requesting for it via the label - to reduce resource usage as in most cases these wont add further coverage to a PR. the current approach parallelizes the 2 jdk results and merges them in the test-report - which may make it less obvious if a test fails only with 1 jdk ideally the alternate jdk runs should run in parallel with the integration test like things...but never got to that I would like to highlight that in case of PR testing its important to provide results for possible multiple PRs - optimizing to use up resources to service a single PR will not be the best use of resources as it could force the system to queue up processing earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
