jtuglu1 commented on code in PR #18735:
URL: https://github.com/apache/druid/pull/18735#discussion_r2512977757
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -1163,13 +1172,15 @@ static class TaskEntry
{
private TaskInfo taskInfo;
+ private final DateTime createdTime;
private DateTime lastUpdatedTime;
private ListenableFuture<TaskStatus> future = null;
private boolean isComplete = false;
- TaskEntry(TaskInfo taskInfo)
+ TaskEntry(TaskInfo taskInfo, DateTime createdTime)
{
this.taskInfo = taskInfo;
+ this.createdTime = createdTime;
this.lastUpdatedTime = DateTimes.nowUtc();
Review Comment:
I think this lastUpdatedTime should be how it currently is as it's
referencing the entry's last updated time. The created time is not referring to
the entry, but rather a close approximation to when the task was "submitted" to
the queue (this is before task storage is updated). Let me change `createdTime`
to be `taskCreatedTime` to make that explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
