kfaraz commented on code in PR #18735:
URL: https://github.com/apache/druid/pull/18735#discussion_r2512991823
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -1163,13 +1172,15 @@ static class TaskEntry
{
private TaskInfo taskInfo;
+ private final DateTime createdTime;
private DateTime lastUpdatedTime;
private ListenableFuture<TaskStatus> future = null;
private boolean isComplete = false;
- TaskEntry(TaskInfo taskInfo)
+ TaskEntry(TaskInfo taskInfo, DateTime createdTime)
{
this.taskInfo = taskInfo;
+ this.createdTime = createdTime;
this.lastUpdatedTime = DateTimes.nowUtc();
Review Comment:
Thanks for clarifying. The var name could be taskSubmittedTime. Also, may be
~at~ add a 1-line comment so that we don't get confused again.
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -1163,13 +1172,15 @@ static class TaskEntry
{
private TaskInfo taskInfo;
+ private final DateTime createdTime;
private DateTime lastUpdatedTime;
private ListenableFuture<TaskStatus> future = null;
private boolean isComplete = false;
- TaskEntry(TaskInfo taskInfo)
+ TaskEntry(TaskInfo taskInfo, DateTime createdTime)
{
this.taskInfo = taskInfo;
+ this.createdTime = createdTime;
this.lastUpdatedTime = DateTimes.nowUtc();
Review Comment:
Thanks for clarifying. The var name could be taskSubmittedTime. Also, maybe
add a 1-line comment so that we don't get confused again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
