kfaraz commented on code in PR #18739:
URL: https://github.com/apache/druid/pull/18739#discussion_r2519849860
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/simulate/KafkaResource.java:
##########
@@ -40,7 +40,8 @@
*/
public class KafkaResource extends TestcontainerResource<KafkaContainer>
{
- private static final String KAFKA_IMAGE = "apache/kafka:4.0.0";
+ // Offering an opportunity to override can help some local devs whose system
struggles to run apache/kafka. Overriding with apache/kafka-native can help.
Review Comment:
Let's convert this to a javadoc.
It would be nice to link it in the class level javadoc too.
Also maybe rephrase to something like:
```suggestion
/**
* Kafka Docker image used in embedded tests. The image name is
* read from the system property {@code druid.testing.kafka.image} and
* defaults to {@code apache/kafka}. Environments that cannot run that
* image should set the system property to {@code apache/kafka-native}.
*/
```
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/simulate/KafkaResource.java:
##########
@@ -40,7 +40,8 @@
*/
public class KafkaResource extends TestcontainerResource<KafkaContainer>
{
- private static final String KAFKA_IMAGE = "apache/kafka:4.0.0";
+ // Offering an opportunity to override can help some local devs whose system
struggles to run apache/kafka. Overriding with apache/kafka-native can help.
+ private static final String KAFKA_IMAGE =
System.getProperty("druid.kafka.test.image", "apache/kafka:4.0.0");
Review Comment:
Nit: Should we use the name `druid.testing.kafka.image` to align with the
Druid image property name used in `DruidContainerResource`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
