clintropolis commented on code in PR #18742:
URL: https://github.com/apache/druid/pull/18742#discussion_r2529239884
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/query/QueryVirtualStorageTest.java:
##########
@@ -152,88 +158,141 @@ void testQueryPartials()
"select count(*) from \"%s\" WHERE __time >= TIMESTAMP '2015-09-12
14:00:00' and __time < TIMESTAMP '2015-09-12 19:00:00'",
"select count(*) from \"%s\" WHERE __time >= TIMESTAMP '2015-09-12
19:00:00' and __time < TIMESTAMP '2015-09-13 00:00:00'"
};
- final long[] expectedResults = new long[] {
- 9770,
- 10524,
- 10267,
- 8683
- };
+ final long[] expectedResults = new long[]{9770, 10524, 10267, 8683};
+ final long[] expectedLoads = new long[]{8L, 6L, 5L, 5L};
+
+
+ LatchableEmitter emitter = historical.latchableEmitter();
+ // sleep to clear out the pipe to get zerod out storage monitor metrics
and then flush (which clears out the
+ // internal events stores in test emitter)
+ sleepForStorageMonitor();
Review Comment:
i had some trouble getting waiting for events from the same monitor to work,
looking into the code i think i see why, waitForEvent doesn't necessarily wait
for the next event, it finds any processed matching event too, i believe i
misunderstood what this method did, I think i need a version that skips any
already emitted events and only waits for the next one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
